[lld] r307039 - [ELF] - Simplify allocateHeaders(). NFC.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 4 08:13:01 PDT 2017


George Rimar <grimar at accesssoftek.com> writes:

>>Nice!
>>
>>Do you need the llvm:: prefix?
>>
>>Cheers,
>>Rafael
>
> Actually no, but we always use prefix in LLD code for find_if,
> should we remove it in all places then ?
> (Honestly I am not sure. We never do "using namespace std",
> so for consistency with std::find_if I would probably leave llvm::find_if,
> it looks a bit more common for me).
>
> The rest LLVM code uses both find_if/llvm::find_if forms even
> if have using namespace llvm; in file.

Sounds reasonable.

Thanks,
Rafael


More information about the llvm-commits mailing list