[PATCH] D34595: Changed Opts.EABIVersion type string to llvm::EABI enum class

[Yuka Takahashi via Phabricator via llvm-commits]

yamaguchi added inline comments.


================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2550
     StringRef Value = A->getValue();
     llvm::EABI EABIVersion = llvm::StringSwitch<llvm::EABI>(Value)
                                  .Case("default", llvm::EABI::Default)
----------------
ruiu wrote:
> How about assigning directly to Opts.EABIVersion? If you do, you can eliminate this temporary variable.
@ruiu 
I thought about it, but I was not sure if we can set llvm::EABI::Unknown to Opts.EABIVersion.


https://reviews.llvm.org/D34595