[PATCH] D34595: Changed Opts.EABIVersion type string to llvm::EABI enum class

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 30 19:56:10 PDT 2017


ruiu added inline comments.


================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2550
     StringRef Value = A->getValue();
     llvm::EABI EABIVersion = llvm::StringSwitch<llvm::EABI>(Value)
                                  .Case("default", llvm::EABI::Default)
----------------
How about assigning directly to Opts.EABIVersion? If you do, you can eliminate this temporary variable.


https://reviews.llvm.org/D34595





More information about the llvm-commits mailing list