[PATCH] D34667: [Demangler] [DO NOT SUBMIT] Initial patch for Microsoft demangler.

Eugene Zemtsov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 27 15:05:16 PDT 2017


eugene added inline comments.


================
Comment at: llvm/lib/Demangle/MicrosoftDemangle.cpp:189
+  // Parser functions. This is a recursive-descendent parser.
+  void read_var_type(Type &ty);
+  void read_member_func_type(Type &ty);
----------------
Here a below a lot of function names violate LLVM's conventions (http://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly)

Please let me know if that document is obsolete.



https://reviews.llvm.org/D34667





More information about the llvm-commits mailing list