[PATCH] D34667: [Demangler] [DO NOT SUBMIT] Initial patch for Microsoft demangler.

[David Majnemer via Phabricator via llvm-commits]

majnemer added inline comments.


================
Comment at: llvm/lib/Demangle/MicrosoftDemangle.cpp:491-506
+  if (consume("PEA")) {
+    ty.prim = Ptr;
+    ty.ptr = alloc();
+    read_var_type(*ty.ptr);
+    return;
+  }
+
----------------
Isn't 'E' only for 64-bit?


================
Comment at: llvm/lib/Demangle/MicrosoftDemangle.cpp:599-618
+  if (consume("T__m64@@"))
+    return M64;
+  if (consume("T__m128@@"))
+    return M128;
+  if (consume("U__m128d@@"))
+    return M128d;
+  if (consume("T__m128i@@"))
----------------
These should be handled as normal structs and unions.


================
Comment at: llvm/lib/Demangle/MicrosoftDemangle.cpp:810
+
+// Write a symbo name. C at B@A is converted to A::B::C.
+void Demangler::write_name(String s) {
----------------
symbo -> symbol.


https://reviews.llvm.org/D34667