[PATCH] D34652: [x86] add SBB optimization for SETAE (uge) condition code

Zvi Rackover via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 26 23:47:24 PDT 2017


zvi added inline comments.


================
Comment at: test/CodeGen/X86/sbb.ll:149
 ; CHECK:       # BB#0:
-; CHECK-NEXT:    xorl %eax, %eax
 ; CHECK-NEXT:    cmpl %esi, %edi
+; CHECK-NEXT:    sbbl %eax, %eax
----------------
zvi wrote:
> AFAIK, the processor does avoid false-dependency stalls for the case 'sbb EAX EAX' (unlike xor's and sub's).
> So we may want to ensure a 'xor EAX EAX' is placed before.
Typo fix: the processor does **not** avoid false-dependency stalls for the case 'sbb EAX EAX'


https://reviews.llvm.org/D34652





More information about the llvm-commits mailing list