[PATCH] D34362: [LNT] Support for different DataSet usage in Polybench for "lnt runtest nt"

Utpal Bora via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 25 23:45:21 PDT 2017


cs14mtech11017 added a comment.

In https://reviews.llvm.org/D34362#789280, @cmatthews wrote:

> It makes more sense to me to be using the --make-param flag to pass a test specific configuration options.  If you want to add all these size classes, all the tests should support them, or have them mapped back to nearest size the tests can handle.


I feel having a common flag for test data sizes is better than having to pass them as test specific flag. As you suggested, we can map them back to nearest data sizes for the other tests. I was working with Polybench, so did not look into other tests.  Will proceed with it if everyone agrees on adding a flag like "--testdatasizes=mini|small|medium|large|extra_large" and aliasing --small and --large for backward compatibility.


Repository:
  rL LLVM

https://reviews.llvm.org/D34362





More information about the llvm-commits mailing list