[PATCH] D34362: [LNT] Support for different DataSet usage in Polybench for "lnt runtest nt"

Utpal Bora via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 25 23:36:35 PDT 2017


cs14mtech11017 added a comment.

In https://reviews.llvm.org/D34362#789152, @MatzeB wrote:

> - Indeed, active test-suite development is done in the cmake build (test_suite.py in lnt). You may still change nt.py but landing features exclusively there would be bad.


Thanks for letting me know. Will update for both.

> - It seems the llvm test-suite today only checks for `SMALL_PROBLEM_SIZE`, occasionally `LARGE_PROBLEM_SIZE` and for SPEC you can choose the size manually. Do you plan to change the test-suite for the new sizes? We should probably do further discussions there.

I added these options only for Polybench. Have not inspected the other benchmarks. I would like to discuss how we can map these sizes for other benchmarks? One we agree upon something, I can make the changes for the test-suite.

> - Do you plan to set any rules/expectations on those new sizes? (Something like "mini" finished in half the time than "small")

I have not thought about it yet.

> - Out of interest: Why do you need finer control over the problem sizes?

I am working with Polybench, which supports multiple input dataset sizes. I did these changes for my experiments and thought it would be better to upload the changes for the community.


Repository:
  rL LLVM

https://reviews.llvm.org/D34362





More information about the llvm-commits mailing list