[PATCH] D32272: [XRay] Add Google Benchmark library + initial XRay benchmarks

Kristof Beyls via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 23 07:53:36 PDT 2017


kristof.beyls added a comment.

In https://reviews.llvm.org/D32272#789006, @hfinkel wrote:

> In https://reviews.llvm.org/D32272#788932, @dberris wrote:
>
> > LGTM for the most part, thanks for making the changes, it's much simpler now.
> >
> > Thoughts @MatzeB? I think we can work on running/reporting the microbenchmarks data later, in changes to LNT.
>
>
> Can you please summarize the state of this and the eventual goal? It looks like:
>
> 1. Eventually, we need a new LNT plugin (i.e. something like what we have in LNTBased/*) that understands how to interpret the output of the Google benchmark library.


I hope this could all be done within the test-suite, probably extending test-suite/litsupport. I hope/think that no changes to LNT will be needed, but I haven't investigated myself.
For example, I'm thinking that test-suite/litsupport could end up reporting the execution time of a single iteration of the code benchmarked with the Google Benchmark library, and that will map neatly to concepts already understood by LNT.


https://reviews.llvm.org/D32272





More information about the llvm-commits mailing list