[PATCH] D32272: [XRay] Add Google Benchmark library + initial XRay benchmarks

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 23 07:42:16 PDT 2017


hfinkel added a comment.

In https://reviews.llvm.org/D32272#788932, @dberris wrote:

> LGTM for the most part, thanks for making the changes, it's much simpler now.
>
> Thoughts @MatzeB? I think we can work on running/reporting the microbenchmarks data later, in changes to LNT.


Can you please summarize the state of this and the eventual goal? It looks like:

1. Eventually, we need a new LNT plugin (i.e. something like what we have in LNTBased/*) that understands how to interpret the output of the Google benchmark library.
2. Right now we don't have that, so you're just fixing the number of iterations to make the tests have meaningful overall times.

Is that correct. Am I missing anything?

I'm happy to see this happening; I'd also like to convert TSVC to use the Google benchmark library and add other benchmarks of similar type in a similar fashion.


https://reviews.llvm.org/D32272





More information about the llvm-commits mailing list