[PATCH] D34545: [AMDGPU] Simplify setcc (sext from i1 b), -1|0, cc

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 22 17:37:00 PDT 2017


rampitec added a comment.

In https://reviews.llvm.org/D34545#788670, @arsenm wrote:

> There are already an extensive number of combines that do this sort of thing in the generic DAGcombiner. Have you looked into why those aren't working? I know some are broken because they don't properly check the TargetBooalenContents


These patterns are quite specific to our way of bool deserialization. Moreover, just like previous it is not always beneficial to do, it all depends where do we expect to have initial bool value.


https://reviews.llvm.org/D34545





More information about the llvm-commits mailing list