[PATCH] D34355: [LLD][ELF] Define _GLOBAL_OFFSET_TABLE_ to base of .got for ARM

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Yes, overall looking good, but I have one question.



================
Comment at: ELF/Writer.cpp:1145-1147
+    if ((SS == InX::Got || SS ==InX::MipsGot) &&
+        Symtab<ELFT>::X->find("_GLOBAL_OFFSET_TABLE_"))
+      continue;
----------------
Doesn't this always succeed unless the -r option is given? It seems _GLOBAL_OFFSET_TABLE_ is added unconditionally, so `find` should return something non-null.


https://reviews.llvm.org/D34355