[PATCH] D34355: [LLD][ELF] Define _GLOBAL_OFFSET_TABLE_ to base of .got for ARM

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 22 09:26:15 PDT 2017


Peter Smith via Phabricator <reviews at reviews.llvm.org> writes:

> @@ -1147,6 +1142,9 @@
>      OutputSection *OS = SS->getParent();
>      if (!SS->empty() || !OS)
>        continue;
> +    if ((SS == InX::Got || SS ==InX::MipsGot) &&
> +        Symtab<ELFT>::X->find("_GLOBAL_OFFSET_TABLE_"))
> +      continue;

Can you just set HasGotOffRel somewhere?

LGTM with that.

Rui, do you agree?

Cheers,
Rafael


More information about the llvm-commits mailing list