[PATCH] D34491: [PDB] Fix reading of clang-generated PDBs by CVDump.

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 22 09:41:46 PDT 2017


zturner added inline comments.


================
Comment at: llvm/lib/DebugInfo/PDB/Native/NamedStreamMap.cpp:87
+    assert(Item != Mapping.end());
+    if (auto EC = Writer.writeCString(Item->getKey()))
       return EC;
----------------
amccarth wrote:
> Just to make sure I understand ... the old way iterated through everything in Mapping, and the new way iterates only through the three streams in OrderedStreamNames.  Will there ever be anything in the Mapping besides those three streams?
Not quite right.  The new way still iterates through everything in Mapping.  These 3 strings are the only 3 strings that were ever there to begin with.  The difference is that when iterating `Mapping`, you can't guarantee the order the results will be returned in, so they were being returned in a different order.  We still end up with the same hash table, we've just inserted the items in a determined ordering.


https://reviews.llvm.org/D34491





More information about the llvm-commits mailing list