[PATCH] D34491: [PDB] Fix reading of clang-generated PDBs by CVDump.

Adrian McCarthy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 22 07:57:47 PDT 2017


amccarth added inline comments.


================
Comment at: llvm/lib/DebugInfo/PDB/Native/NamedStreamMap.cpp:87
+    assert(Item != Mapping.end());
+    if (auto EC = Writer.writeCString(Item->getKey()))
       return EC;
----------------
Just to make sure I understand ... the old way iterated through everything in Mapping, and the new way iterates only through the three streams in OrderedStreamNames.  Will there ever be anything in the Mapping besides those three streams?


https://reviews.llvm.org/D34491





More information about the llvm-commits mailing list