[PATCH] D34459: [ELF] Better handling of _GLOBAL_OFFSET_TABLE_

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: ELF/Writer.cpp:830
   // hidden one to avoid the undefined symbol error.
-  Symtab<ELFT>::X->addIgnored("_GLOBAL_OFFSET_TABLE_");
+  ElfSym::Got = Symtab<ELFT>::X->addIgnored("_GLOBAL_OFFSET_TABLE_");
 
----------------
I think that if you create this symbol with addOptionalRegular you won't need a special case in Relocations.cpp.


Repository:
  rL LLVM

https://reviews.llvm.org/D34459