[PATCH] D34459: [ELF] Better handling of _GLOBAL_OFFSET_TABLE_

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 21 10:36:55 PDT 2017


ruiu added a comment.

I don't have any further comments, but can you please update the patch?



================
Comment at: ELF/Relocations.cpp:402
 
+  if (&Body == ElfSym::Got)
+    return true;
----------------
Add a comment saying that a relative relocation against the beginning of .got can always be computed at link-time as each ELF module has its own .got section.


Repository:
  rL LLVM

https://reviews.llvm.org/D34459





More information about the llvm-commits mailing list