[PATCH] D34255: [PowerPC] define target hook isReallyTriviallyReMaterializable

[Lei Huang via Phabricator via llvm-commits]

lei added inline comments.


================
Comment at: lib/Target/PowerPC/PPCInstrInfo.cpp:295
 
+bool PPCInstrInfo::isReallyTriviallyReMaterializable(const MachineInstr &MI,
+                                                     AliasAnalysis *AA) const {
----------------
echristo wrote:
> This needs a comment as to why each of these need to be marked as rematerializable here rather than in the .td file.
Will add:

// The Rematerializable flag is deprecated and if it is set, isReallyTriviallyReMaterializable() method need to be called to verify the instruction is really rematable.


https://reviews.llvm.org/D34255