[PATCH] D34255: [PowerPC] define target hook isReallyTriviallyReMaterializable

[Eric Christopher via Phabricator via llvm-commits]

echristo added inline comments.


================
Comment at: lib/Target/PowerPC/PPCInstrInfo.cpp:295
 
+bool PPCInstrInfo::isReallyTriviallyReMaterializable(const MachineInstr &MI,
+                                                     AliasAnalysis *AA) const {
----------------
This needs a comment as to why each of these need to be marked as rematerializable here rather than in the .td file.


================
Comment at: lib/Target/PowerPC/PPCInstrInfo.cpp:299
+  default: 
+    llvm_unreachable("Can not confirm opcode is really rematerializable");
+    break;
----------------
I'm not sure an unreachable is the right thing here - usually this is reserved for switch cases that can't be true rather than just a return false.


https://reviews.llvm.org/D34255