[PATCH] D34176: [cmake] Make sure that -Wcast-qual is not a error in preparation for clang's -Wcast-qual for C++

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 19 12:58:03 PDT 2017


On Mon, Jun 19, 2017 at 8:42 AM Roman Lebedev via Phabricator <
reviews at reviews.llvm.org> wrote:

> lebedev.ri added a comment.
>
> Ok, so i suppose libc++ is fine now, thanks to @mclow.lists
> I can not build lldb, so i can not check whether it has similar issues.
> This leaves only the OpenMP?
>
> To reiterate, there are several solutions:
>
> 1. Do nothing, just land https://reviews.llvm.org/D33102, i'm under
> **impression** no current buildbot will break. That, however, will break
> anyone who builds with openmp subproject and with `-DLLVM_ENABLE_WERROR=ON`
> 2. Disable `-Wcast-qual` in openmp
> 3. This approach, which is wrong - disable it globally
> 4. Wait until openmp is fixed. I suppose i could help, though it is really
> better if someone with the actual knowledge about the code fixes these
> warnings...
>

I'd probably suggest taking a look at (4) here. See if there's anything
particularly confusing/bad in the code (I'm happy to answer questions/take
a guess at how to fix the code).

Might want to look at the blame history on the files and add them to this
thread or the code review threads for the changes.

- Dave


>
> I'd really like to hear any thoughts from the openmp people :)
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D34176
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170619/4fd79bc1/attachment.html>


More information about the llvm-commits mailing list