[PATCH] D34176: [cmake] Make sure that -Wcast-qual is not a error in preparation for clang's -Wcast-qual for C++

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 19 08:42:43 PDT 2017


lebedev.ri added a comment.

Ok, so i suppose libc++ is fine now, thanks to @mclow.lists
I can not build lldb, so i can not check whether it has similar issues.
This leaves only the OpenMP?

To reiterate, there are several solutions:

1. Do nothing, just land https://reviews.llvm.org/D33102, i'm under **impression** no current buildbot will break. That, however, will break anyone who builds with openmp subproject and with `-DLLVM_ENABLE_WERROR=ON`
2. Disable `-Wcast-qual` in openmp
3. This approach, which is wrong - disable it globally
4. Wait until openmp is fixed. I suppose i could help, though it is really better if someone with the actual knowledge about the code fixes these warnings...

I'd really like to hear any thoughts from the openmp people :)


Repository:
  rL LLVM

https://reviews.llvm.org/D34176





More information about the llvm-commits mailing list