[PATCH] D34356: [PDB] Don't emit debug info associated with dead chunks

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: lld/COFF/Chunks.h:182
+  // the image. Instead they will end up in the PDB, if one is requested.
+  bool isCodeView() const { return IsCodeViewDebug; }
+
----------------
ruiu wrote:
> Since this function is not called very often, I'd remove the member variable and check the condition every time the function is called.
Isn't this function called by the Writer for every chunk written to the output file?


https://reviews.llvm.org/D34356