[PATCH] D34356: [PDB] Don't emit debug info associated with dead chunks
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 19 11:44:44 PDT 2017
ruiu added inline comments.
================
Comment at: lld/COFF/Chunks.h:182
+ // the image. Instead they will end up in the PDB, if one is requested.
+ bool isCodeView() const { return IsCodeViewDebug; }
+
----------------
Since this function is not called very often, I'd remove the member variable and check the condition every time the function is called.
https://reviews.llvm.org/D34356
More information about the llvm-commits
mailing list