[PATCH] D34089: [llvm-stress] Ensure that the C++11 random device respects its min/max values (PR32585)

Justin Bogner via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 15 16:13:56 PDT 2017


Simon Pilgrim via Phabricator <reviews at reviews.llvm.org> writes:
> RKSimon added a comment.
>
> In https://reviews.llvm.org/D34089#779145, @mclow.lists wrote:
>
>> > Is there a C++11 random class that covers the features we need
>> (same results on different targets, drivable by input seed)?
>>
>> Given that the libc++ `mersenne_twister_engine` tests test
>> specifically that, yes.
>>
>> see <libc++
>> root>/test/std/numerics/rand/rand.eng/rand.eng.mers/ctor_sseq.pass.cpp
>
>
> I've created https://reviews.llvm.org/D34157 for the refactor which is
> going to take a few days, in the meantime are there any objections to
> committing this patch to fix PR32585's current assertion in fuzz
> testing?

No objections. Go ahead and commit this in the meantime.


More information about the llvm-commits mailing list