[PATCH] D34168: [cfi] CFI-ICall for ThinLTO.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Transforms/IPO/CrossDSOCFI.cpp:98
 
+  NamedMDNode *CfiFunctionsMD = M.getNamedMetadata("cfi.functions");
+  if (CfiFunctionsMD) {
----------------
Please add test coverage for this code.


================
Comment at: lib/Transforms/IPO/LowerTypeTests.cpp:39
 #include "llvm/Transforms/IPO.h"
+#include "llvm/Transforms/IPO/LowerTypeTests.h"
 #include "llvm/Transforms/Utils/BasicBlockUtils.h"
----------------
This should be the first include.


Repository:
  rL LLVM

https://reviews.llvm.org/D34168