[PATCH] D34168: [cfi] CFI-ICall for ThinLTO.
Evgenii Stepanov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 14 17:10:26 PDT 2017
eugenis added inline comments.
================
Comment at: lib/Transforms/IPO/LowerTypeTests.cpp:1498
+ auto &V = ExportedFunctions[FunctionName];
+ if (isDefinition >= V.first)
+ V = {isDefinition, FuncMD};
----------------
eugenis wrote:
> pcc wrote:
> > I think this would be clearer as `if (!V.first)`.
> >
> > Could `V.first` be uninitialized at this point?
> It's initialized to zero, which is what we want.
I've rewrote this code in a more explicit way.
Repository:
rL LLVM
https://reviews.llvm.org/D34168
More information about the llvm-commits
mailing list