[PATCH] D34143: Handling of TRAP during isel

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

Needs testcase.  (-verify-machineinstrs will run the verifier even if it's off by default for your target.)

Some targets special-case Intrinsic::trap in FastISel; need separate testcases for that (and maybe fixes).

I'm not sure I agree with the approach; just because it doesn't return doesn't mean you have to mark it a terminator.  A call to the C library function abort() is also a "terminator", but we don't treat it as one because it's just simpler to treat it like a regular call.


https://reviews.llvm.org/D34143