[PATCH] D34142: [ARM] Add macro fusion for AES instructions.

Javed Absar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 14 09:41:13 PDT 2017


javed.absar added inline comments.


================
Comment at: lib/Target/ARM/ARMTargetMachine.cpp:399
+    const ARMSubtarget &ST = C->MF->getSubtarget<ARMSubtarget>();
+    if (ST.hasFuseAES())
+      DAG->addMutation(createARMMacroFusionDAGMutation());
----------------
evandro wrote:
> Granted that `fuse-aes` is currently the only fusion, but I wonder if it´d make sense to create a more encompassing `hasFusion()` method that would combine all and any instruction fusion.
In light of that, should 'shouldScheduleAdjacent' be renamed 'shouldScheduleAdjacentAES' ?
I understand you have an equivalent patch for AArch64 of this,  so any ask here would need parallel changes there and depending on how things converge on https://reviews.llvm.org/D34144 


https://reviews.llvm.org/D34142





More information about the llvm-commits mailing list