[PATCH] D33773: [ARM] llc -arm-execute-only with floating point runs into UNREACHABLE

Tue Jun 13 08:29:27 PDT 2017

labrinea updated this revision to Diff 102335.
labrinea added a comment.

Hi Christof,

I wasn't aware that PIC is not compatible with execute-only. Indeed a constant pool in text is being generated if I remove those checks. It contains the distance between the constant pool that is located in the data section and the address of the "current" instruction. I've kept those checks against constant pool generation and added another one in ARMAsmPrinter.cpp. I've also removed the PIC tests since they are now irrelevant.

Cheers,
Alexandros

https://reviews.llvm.org/D33773

Files:
  lib/Target/ARM/ARMAsmPrinter.cpp
  lib/Target/ARM/ARMISelLowering.cpp
  lib/Target/ARM/ARMISelLowering.h
  test/CodeGen/ARM/constantfp.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D33773.102335.patch
Type: text/x-patch
Size: 8106 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170613/ca68a0c8/attachment.bin>