[PATCH] D33773: [ARM] llc -arm-execute-only with floating point runs into UNREACHABLE
Christof Douma via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 13 06:07:37 PDT 2017
christof added a comment.
The execute-only and PIC features cannot be enabled together. You probably should leave that unreachable in `lib/Target/ARM/ARMAsmPrinter.cpp` in place. You might even add one under the case `ARM::CONSTPOOL_ENTRY` in that file for good measure.
Otherwise, I'm happy to approve the constpool to global constant lowering
================
Comment at: test/CodeGen/ARM/constantfp.ll:226
+; CHECK-XO-PIC: [[LABEL1]]:
+; CHECK-XO-PIC: .long [[LABEL3:.?LPC[0-9]+_[0-9]+]]-([[LABEL2]]+4)
+; CHECK-XO-PIC: .rodata
----------------
- Sorry, but this is wrong. The point of execute-only is that there is no data access to any text section.
https://reviews.llvm.org/D33773
More information about the llvm-commits
mailing list