[PATCH] D32746: [globalisel][legalizer] G_LOAD/G_STORE NarrowScalar should not emit G_GEP x, 0.

Igor Breger via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 13 00:15:01 PDT 2017


igorb added inline comments.


================
Comment at: lib/CodeGen/GlobalISel/LegalizerHelper.cpp:247
+
+      MIRBuilder.materializeGEP(SrcReg, MI.getOperand(1).getReg(), LLT::scalar(64), Adjustment);
 
----------------
qcolombet wrote:
> Is this clang-formated?
> In the browser it looks larger than 80-col, but it may just be an impression.
could you calculate offset type base on pointer size ?  So it will be legal for 32bit targets .


https://reviews.llvm.org/D32746





More information about the llvm-commits mailing list