[PATCH] D32746: [globalisel][legalizer] G_LOAD/G_STORE NarrowScalar should not emit G_GEP x, 0.

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added a comment.

The new helper looks good.
Nitpicks below.



================
Comment at: lib/CodeGen/GlobalISel/LegalizerHelper.cpp:247
+
+      MIRBuilder.materializeGEP(SrcReg, MI.getOperand(1).getReg(), LLT::scalar(64), Adjustment);
 
----------------
Is this clang-formated?
In the browser it looks larger than 80-col, but it may just be an impression.


================
Comment at: lib/CodeGen/GlobalISel/LegalizerHelper.cpp:280
+      } else
+        DstReg = MI.getOperand(1).getReg();
+
----------------
Shouldn't we call materializeGEP here too for the whole if-then block?


https://reviews.llvm.org/D32746