[PATCH] D34093: ELF: Move section merging before ICF. NFCI.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lld/ELF/Driver.cpp:1003
       InputSections.push_back(cast<InputSection>(S));
+  if (!Config->Relocatable)
+    InputSections.push_back(createCommentSection<ELFT>());
----------------
Can you add a comment saying that this adds a .comment section containing a version string, and we have to do that before mergeSections because the .comment section is a mergeable section?


https://reviews.llvm.org/D34093