[PATCH] D34093: ELF: Move section merging before ICF. NFCI.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 11 16:47:55 PDT 2017


pcc marked 2 inline comments as done.
pcc added inline comments.


================
Comment at: lld/ELF/Driver.cpp:1007-1008
 
-  // Do size optimizations: garbage collection and identical code folding.
+  // Do size optimizations: garbage collection, merging of SHF_MERGE sections
+  // and identical code folding.
   if (Config->GcSections)
----------------
ruiu wrote:
> I first read this comment as markLive does all these things. I guess this comment describes all the code until writeResult. This is a bit confusing.
Okay, now all the size optimizations are in one block like before.


https://reviews.llvm.org/D34093





More information about the llvm-commits mailing list