[PATCH] D34063: [ThinLTO][llvm-lto2] Dump YAML for module summaries

[Charles Saternos via Phabricator via llvm-commits]

ncharlie added inline comments.


================
Comment at: include/llvm/IR/ModuleSummaryIndex.h:537
+  // Maps Oid GUID to the stringified value name (for dissassembly)
+  std::map<GlobalValue::GUID, std::string> OidToValueName;
+
----------------
mehdi_amini wrote:
> ncharlie wrote:
> > mehdi_amini wrote:
> > > Do we want this on all the time? Is this a fundamental property of the Index?
> > > It isn't clear to me if it isn't just a debugging tool that map to the IR when available right now?
> > How would you recommend making this an optional debugging option? Would a constructor argument work?
> Is this information in the index in the bitcode? 
> If not then it can be reconstructed at dump time.
The reason I'm storing the map in the index is because I only have access to the ValueName when the bitcode is being parsed in ModuleSummaryIndexBitcodeReader (see BitcodeReader.cpp:4715 in this patch). Also, when the YAML is being generated, I'm only given a pointer to a ModuleSummaryIndex, which is why the map is in that class.


https://reviews.llvm.org/D34063