[PATCH] D34063: [ThinLTO][llvm-lto2] Dump YAML for module summaries

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: include/llvm/IR/ModuleSummaryIndex.h:537
+  // Maps Oid GUID to the stringified value name (for dissassembly)
+  std::map<GlobalValue::GUID, std::string> OidToValueName;
+
----------------
ncharlie wrote:
> mehdi_amini wrote:
> > Do we want this on all the time? Is this a fundamental property of the Index?
> > It isn't clear to me if it isn't just a debugging tool that map to the IR when available right now?
> How would you recommend making this an optional debugging option? Would a constructor argument work?
Is this information in the index in the bitcode? 
If not then it can be reconstructed at dump time.


https://reviews.llvm.org/D34063