[PATCH] D34020: Implement COFF emission for parsed Windows Resource ( .res) files.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: llvm/lib/Object/WindowsResource.cpp:391
+  return Now;
+}
+
----------------
zturner wrote:
> majnemer wrote:
> > ruiu wrote:
> > > Incremental linking sees file itself's timestamp instead of a timestamp field inside a file, no?
> > > 
> > > Reproducible build is generally important in many use cases, and you don't want to break that property unless breaking it is absolutely necessary. It is so convenient if you can always create an identical output from the same source tree.
> > The MS linker actually uses the time in the file. I learned this the hard way getting LLVM obj files compatible with LINK.exe
> Shouldn't we do whatever MS does?
If that's needed, then well, we have to do that.


https://reviews.llvm.org/D34020