[PATCH] D34020: Implement COFF emission for parsed Windows Resource ( .res) files.

[Zachary Turner via llvm-commits]

Our comments overlapped.  Basically, what majnemer@ said.

On Thu, Jun 8, 2017 at 5:08 PM Zachary Turner via Phabricator <
reviews at reviews.llvm.org> wrote:

> zturner added inline comments.
>
>
> ================
> Comment at: llvm/lib/Object/WindowsResource.cpp:391
> +  return Now;
> +}
> +
> ----------------
> majnemer wrote:
> > ruiu wrote:
> > > Incremental linking sees file itself's timestamp instead of a
> timestamp field inside a file, no?
> > >
> > > Reproducible build is generally important in many use cases, and you
> don't want to break that property unless breaking it is absolutely
> necessary. It is so convenient if you can always create an identical output
> from the same source tree.
> > The MS linker actually uses the time in the file. I learned this the
> hard way getting LLVM obj files compatible with LINK.exe
> Shouldn't we do whatever MS does?
>
>
> https://reviews.llvm.org/D34020
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170609/fd6b2900/attachment.html>