[PATCH] D34015: Allow subsections in raw output mode to be printed in the order they appear in the file.

[Zachary Turner via Phabricator via llvm-commits]

zturner marked an inline comment as done.
zturner added inline comments.


================
Comment at: llvm/lib/DebugInfo/CodeView/DebugSubsectionVisitor.cpp:39
+  assert(SR.kind() == DebugSubsectionKind::StringTable);
+  if (Strings)
+    return;
----------------
inglorion wrote:
> Should it be an error if you call initializeStrings when Strings is already set? Or should we at least assert against it? Same with checksums below.
I tried that, and it causes problems in follow-up patches.  PDB has a global string table, but string tables can also appear inside of debug subsections.  This isn't really supposed to happen in practice (they appear in the .debug$S section in object files, but in the global string table in PDB files), but it's useful to be able to test proper operation of the StringTable subsection by manually constructing one with both a global and local string table.  So I ended up removing the check.


https://reviews.llvm.org/D34015