[PATCH] D34015: Allow subsections in raw output mode to be printed in the order they appear in the file.

[Bob Haarman via Phabricator via llvm-commits]

inglorion added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/CodeView/DebugSubsectionVisitor.h:29
 
+struct DebugSubsectionState {
+public:
----------------
Since you have both public and private members, please declare this as a class instead of a struct.


================
Comment at: llvm/lib/DebugInfo/CodeView/DebugSubsectionVisitor.cpp:39
+  assert(SR.kind() == DebugSubsectionKind::StringTable);
+  if (Strings)
+    return;
----------------
Should it be an error if you call initializeStrings when Strings is already set? Or should we at least assert against it? Same with checksums below.


https://reviews.llvm.org/D34015