[PATCH] D33969: Bitcode: Introduce a BitcodeFileContents data type. NFCI.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: llvm/include/llvm/Bitcode/BitcodeReader.h:106
+  Expected<BitcodeFileContents> getBitcodeFileContents(MemoryBufferRef Buffer);
+  struct BitcodeFileContents {
+    std::vector<BitcodeModule> Mods;
----------------
tejohnson wrote:
> Suggest moving the struct def above the function declaration.
Will do


================
Comment at: llvm/include/llvm/Object/IRObjectFile.h:73
 struct File {
   std::vector<BitcodeModule> Mods;
   SmallVector<char, 0> Symtab, Strtab;
----------------
tejohnson wrote:
> Should this use the new type?
Yes, I'll do the obvious search and replace on these patches when I commit them.


https://reviews.llvm.org/D33969