[PATCH] D33969: Bitcode: Introduce a BitcodeFileContents data type. NFCI.
Teresa Johnson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 8 13:46:52 PDT 2017
tejohnson added inline comments.
================
Comment at: llvm/include/llvm/Bitcode/BitcodeReader.h:106
+ Expected<BitcodeFileContents> getBitcodeFileContents(MemoryBufferRef Buffer);
+ struct BitcodeFileContents {
+ std::vector<BitcodeModule> Mods;
----------------
Suggest moving the struct def above the function declaration.
================
Comment at: llvm/include/llvm/Object/IRObjectFile.h:73
struct File {
std::vector<BitcodeModule> Mods;
SmallVector<char, 0> Symtab, Strtab;
----------------
Should this use the new type?
https://reviews.llvm.org/D33969
More information about the llvm-commits
mailing list