[PATCH] D33872: [llvm-readobj] Accept -S as an alias for --sections

[Rafael Avila de Espindola via llvm-commits]

I am fine with this.

I am also a fan of having a gnu like llvm-readelf.

The difference is command line option exists because llvm-readobj was
born to be a FileCheck friendly dumper. The support for a readelf mode
was added after that.

I am not sure if it is better to implement llvm-readelf as is now or
with refactoring some of the llvm-readobj code to a library.

In any case, I am OK with giving this (changing the options) a try.

Cheers,
Rafael

Davide Italiano via Phabricator <reviews at reviews.llvm.org> writes:

> davide added a comment.
>
> In https://reviews.llvm.org/D33872#772291, @mcgrathr wrote:
>
>> This change is orthogonal to the -s switch and I'd like to get it landed independent of decisions about -s.
>>  I only brought it up to point out the limitations of compatibility with readelf even after these changes.
>>  But these alone are incremental progress and cover all the uses cases for readelf in the build of the system I happen to be building.
>
>
> Yes, this one LGTM as well. My main concern stems from the divergence with GNU (with no good reason).
> tl;dr: I'd like this to be discussed further (independently from this patch). Whether this should happen as part of this review (or on llvm-dev), I have no strong opinion about [but a slight preference for the latter].
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D33872