[PATCH] D33872: [llvm-readobj] Accept -S as an alias for --sections

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 3 17:17:13 PDT 2017


davide added a comment.

In https://reviews.llvm.org/D33872#772291, @mcgrathr wrote:

> This change is orthogonal to the -s switch and I'd like to get it landed independent of decisions about -s.
>  I only brought it up to point out the limitations of compatibility with readelf even after these changes.
>  But these alone are incremental progress and cover all the uses cases for readelf in the build of the system I happen to be building.


Yes, this one LGTM as well. My main concern stems from the divergence with GNU (with no good reason).
tl;dr: I'd like this to be discussed further (independently from this patch). Whether this should happen as part of this review (or on llvm-dev), I have no strong opinion about [but a slight preference for the latter].


Repository:
  rL LLVM

https://reviews.llvm.org/D33872





More information about the llvm-commits mailing list