[llvm] r304498 - [PredicateInfo] Enable -reverse-iterate tests only for +Asserts builds

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 2 11:37:27 PDT 2017


Uh, this flag isn't *necessarily* available for asserts builds. It is
available if ABI breaking checks are enabled. These aren't (exactly) the
same.

On Thu, Jun 1, 2017 at 4:53 PM Mandeep Singh Grang via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: mgrang
> Date: Thu Jun  1 18:52:59 2017
> New Revision: 304498
>
> URL: http://llvm.org/viewvc/llvm-project?rev=304498&view=rev
> Log:
> [PredicateInfo] Enable -reverse-iterate tests only for +Asserts builds
>
> Summary: The flag -reverse-iterate is present only on +Asserts builds.
>
> Reviewers: dberlin, davide, RKSimon, efriedma, chapuni
>
> Reviewed By: efriedma, chapuni
>
> Subscribers: chapuni, llvm-commits
>
> Differential Revision: https://reviews.llvm.org/D33795
>
> Added:
>     llvm/trunk/test/Transforms/Util/PredicateInfo/condprop2.ll
>       - copied, changed from r304492,
> llvm/trunk/test/Transforms/Util/PredicateInfo/condprop.ll
>     llvm/trunk/test/Transforms/Util/PredicateInfo/testandor2.ll
>       - copied, changed from r304492,
> llvm/trunk/test/Transforms/Util/PredicateInfo/testandor.ll
> Modified:
>     llvm/trunk/test/Transforms/Util/PredicateInfo/condprop.ll
>     llvm/trunk/test/Transforms/Util/PredicateInfo/testandor.ll
>
> Modified: llvm/trunk/test/Transforms/Util/PredicateInfo/condprop.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/Util/PredicateInfo/condprop.ll?rev=304498&r1=304497&r2=304498&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/Transforms/Util/PredicateInfo/condprop.ll (original)
> +++ llvm/trunk/test/Transforms/Util/PredicateInfo/condprop.ll Thu Jun  1
> 18:52:59 2017
> @@ -1,6 +1,5 @@
>  ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
>  ; RUN: opt -print-predicateinfo -analyze  < %s 2>&1 | FileCheck %s
> -; RUN: opt -print-predicateinfo -analyze -reverse-iterate  < %s 2>&1 |
> FileCheck %s
>
>  @a = external global i32               ; <i32*> [#uses=7]
>
>
> Copied: llvm/trunk/test/Transforms/Util/PredicateInfo/condprop2.ll (from
> r304492, llvm/trunk/test/Transforms/Util/PredicateInfo/condprop.ll)
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/Util/PredicateInfo/condprop2.ll?p2=llvm/trunk/test/Transforms/Util/PredicateInfo/condprop2.ll&p1=llvm/trunk/test/Transforms/Util/PredicateInfo/condprop.ll&r1=304492&r2=304498&rev=304498&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/Transforms/Util/PredicateInfo/condprop.ll (original)
> +++ llvm/trunk/test/Transforms/Util/PredicateInfo/condprop2.ll Thu Jun  1
> 18:52:59 2017
> @@ -1,5 +1,7 @@
> +; REQUIRES: asserts
> +; NOTE: The flag -reverse-iterate is present only in a +Asserts build.
> +; Hence, this test has been split from condprop.ll to test with
> -reverse-iterate.
>  ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
> -; RUN: opt -print-predicateinfo -analyze  < %s 2>&1 | FileCheck %s
>  ; RUN: opt -print-predicateinfo -analyze -reverse-iterate  < %s 2>&1 |
> FileCheck %s
>
>  @a = external global i32               ; <i32*> [#uses=7]
>
> Modified: llvm/trunk/test/Transforms/Util/PredicateInfo/testandor.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/Util/PredicateInfo/testandor.ll?rev=304498&r1=304497&r2=304498&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/Transforms/Util/PredicateInfo/testandor.ll (original)
> +++ llvm/trunk/test/Transforms/Util/PredicateInfo/testandor.ll Thu Jun  1
> 18:52:59 2017
> @@ -1,6 +1,5 @@
>  ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
>  ; RUN: opt -print-predicateinfo < %s 2>&1 | FileCheck %s
> -; RUN: opt -print-predicateinfo -reverse-iterate < %s 2>&1 | FileCheck %s
>
>  declare void @foo(i1)
>  declare void @bar(i32)
>
> Copied: llvm/trunk/test/Transforms/Util/PredicateInfo/testandor2.ll (from
> r304492, llvm/trunk/test/Transforms/Util/PredicateInfo/testandor.ll)
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/Util/PredicateInfo/testandor2.ll?p2=llvm/trunk/test/Transforms/Util/PredicateInfo/testandor2.ll&p1=llvm/trunk/test/Transforms/Util/PredicateInfo/testandor.ll&r1=304492&r2=304498&rev=304498&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/Transforms/Util/PredicateInfo/testandor.ll (original)
> +++ llvm/trunk/test/Transforms/Util/PredicateInfo/testandor2.ll Thu Jun  1
> 18:52:59 2017
> @@ -1,5 +1,7 @@
> +; REQUIRES: asserts
> +; NOTE: The flag -reverse-iterate is present only in a +Asserts build.
> +; Hence, this test has been split from testandor.ll to test with
> -reverse-iterate.
>  ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
> -; RUN: opt -print-predicateinfo < %s 2>&1 | FileCheck %s
>  ; RUN: opt -print-predicateinfo -reverse-iterate < %s 2>&1 | FileCheck %s
>
>  declare void @foo(i1)
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170602/7ad2c4cf/attachment.html>


More information about the llvm-commits mailing list