<div dir="ltr">Uh, this flag isn't *necessarily* available for asserts builds. It is available if ABI breaking checks are enabled. These aren't (exactly) the same.</div><br><div class="gmail_quote"><div dir="ltr">On Thu, Jun 1, 2017 at 4:53 PM Mandeep Singh Grang via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: mgrang<br>
Date: Thu Jun  1 18:52:59 2017<br>
New Revision: 304498<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=304498&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=304498&view=rev</a><br>
Log:<br>
[PredicateInfo] Enable -reverse-iterate tests only for +Asserts builds<br>
<br>
Summary: The flag -reverse-iterate is present only on +Asserts builds.<br>
<br>
Reviewers: dberlin, davide, RKSimon, efriedma, chapuni<br>
<br>
Reviewed By: efriedma, chapuni<br>
<br>
Subscribers: chapuni, llvm-commits<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D33795" rel="noreferrer" target="_blank">https://reviews.llvm.org/D33795</a><br>
<br>
Added:<br>
    llvm/trunk/test/Transforms/Util/PredicateInfo/condprop2.ll<br>
      - copied, changed from r304492, llvm/trunk/test/Transforms/Util/PredicateInfo/condprop.ll<br>
    llvm/trunk/test/Transforms/Util/PredicateInfo/testandor2.ll<br>
      - copied, changed from r304492, llvm/trunk/test/Transforms/Util/PredicateInfo/testandor.ll<br>
Modified:<br>
    llvm/trunk/test/Transforms/Util/PredicateInfo/condprop.ll<br>
    llvm/trunk/test/Transforms/Util/PredicateInfo/testandor.ll<br>
<br>
Modified: llvm/trunk/test/Transforms/Util/PredicateInfo/condprop.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/Util/PredicateInfo/condprop.ll?rev=304498&r1=304497&r2=304498&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/Util/PredicateInfo/condprop.ll?rev=304498&r1=304497&r2=304498&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/Transforms/Util/PredicateInfo/condprop.ll (original)<br>
+++ llvm/trunk/test/Transforms/Util/PredicateInfo/condprop.ll Thu Jun  1 18:52:59 2017<br>
@@ -1,6 +1,5 @@<br>
 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py<br>
 ; RUN: opt -print-predicateinfo -analyze  < %s 2>&1 | FileCheck %s<br>
-; RUN: opt -print-predicateinfo -analyze -reverse-iterate  < %s 2>&1 | FileCheck %s<br>
<br>
 @a = external global i32               ; <i32*> [#uses=7]<br>
<br>
<br>
Copied: llvm/trunk/test/Transforms/Util/PredicateInfo/condprop2.ll (from r304492, llvm/trunk/test/Transforms/Util/PredicateInfo/condprop.ll)<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/Util/PredicateInfo/condprop2.ll?p2=llvm/trunk/test/Transforms/Util/PredicateInfo/condprop2.ll&p1=llvm/trunk/test/Transforms/Util/PredicateInfo/condprop.ll&r1=304492&r2=304498&rev=304498&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/Util/PredicateInfo/condprop2.ll?p2=llvm/trunk/test/Transforms/Util/PredicateInfo/condprop2.ll&p1=llvm/trunk/test/Transforms/Util/PredicateInfo/condprop.ll&r1=304492&r2=304498&rev=304498&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/Transforms/Util/PredicateInfo/condprop.ll (original)<br>
+++ llvm/trunk/test/Transforms/Util/PredicateInfo/condprop2.ll Thu Jun  1 18:52:59 2017<br>
@@ -1,5 +1,7 @@<br>
+; REQUIRES: asserts<br>
+; NOTE: The flag -reverse-iterate is present only in a +Asserts build.<br>
+; Hence, this test has been split from condprop.ll to test with -reverse-iterate.<br>
 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py<br>
-; RUN: opt -print-predicateinfo -analyze  < %s 2>&1 | FileCheck %s<br>
 ; RUN: opt -print-predicateinfo -analyze -reverse-iterate  < %s 2>&1 | FileCheck %s<br>
<br>
 @a = external global i32               ; <i32*> [#uses=7]<br>
<br>
Modified: llvm/trunk/test/Transforms/Util/PredicateInfo/testandor.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/Util/PredicateInfo/testandor.ll?rev=304498&r1=304497&r2=304498&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/Util/PredicateInfo/testandor.ll?rev=304498&r1=304497&r2=304498&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/Transforms/Util/PredicateInfo/testandor.ll (original)<br>
+++ llvm/trunk/test/Transforms/Util/PredicateInfo/testandor.ll Thu Jun  1 18:52:59 2017<br>
@@ -1,6 +1,5 @@<br>
 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py<br>
 ; RUN: opt -print-predicateinfo < %s 2>&1 | FileCheck %s<br>
-; RUN: opt -print-predicateinfo -reverse-iterate < %s 2>&1 | FileCheck %s<br>
<br>
 declare void @foo(i1)<br>
 declare void @bar(i32)<br>
<br>
Copied: llvm/trunk/test/Transforms/Util/PredicateInfo/testandor2.ll (from r304492, llvm/trunk/test/Transforms/Util/PredicateInfo/testandor.ll)<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/Util/PredicateInfo/testandor2.ll?p2=llvm/trunk/test/Transforms/Util/PredicateInfo/testandor2.ll&p1=llvm/trunk/test/Transforms/Util/PredicateInfo/testandor.ll&r1=304492&r2=304498&rev=304498&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/Util/PredicateInfo/testandor2.ll?p2=llvm/trunk/test/Transforms/Util/PredicateInfo/testandor2.ll&p1=llvm/trunk/test/Transforms/Util/PredicateInfo/testandor.ll&r1=304492&r2=304498&rev=304498&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/Transforms/Util/PredicateInfo/testandor.ll (original)<br>
+++ llvm/trunk/test/Transforms/Util/PredicateInfo/testandor2.ll Thu Jun  1 18:52:59 2017<br>
@@ -1,5 +1,7 @@<br>
+; REQUIRES: asserts<br>
+; NOTE: The flag -reverse-iterate is present only in a +Asserts build.<br>
+; Hence, this test has been split from testandor.ll to test with -reverse-iterate.<br>
 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py<br>
-; RUN: opt -print-predicateinfo < %s 2>&1 | FileCheck %s<br>
 ; RUN: opt -print-predicateinfo -reverse-iterate < %s 2>&1 | FileCheck %s<br>
<br>
 declare void @foo(i1)<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>