[PATCH] D31194: [InstSimplify] Try to Constant Fold the Instruction before simplification

Daniel Berlin via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 2 07:31:50 PDT 2017


Fine by me!

On Fri, Jun 2, 2017 at 3:10 AM, Joey Gouly via Phabricator <
reviews at reviews.llvm.org> wrote:

> joey updated this revision to Diff 101179.
> joey added a comment.
>
> Thanks for that Craig, I had planned on looking at that today so thanks
> for doing it!
>
> I tested with https://reviews.llvm.org/D33801 applied, and it fixes the
> completeness.ll test.
>
> Once Craig's review is finished, is this good to commit?
>
>
> https://reviews.llvm.org/D31194
>
> Files:
>   lib/Analysis/InstructionSimplify.cpp
>   test/Analysis/ConstantFolding/gep-constanfolding-error.ll
>   test/Transforms/InstSimplify/compare.ll
>   test/Transforms/InstSimplify/simplify-nested-bitcast.ll
>   test/Transforms/InstSimplify/vector_gep.ll
>   test/Transforms/NewGVN/completeness.ll
>   test/Transforms/NewGVN/loadforward.ll
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170602/8ae6e162/attachment.html>


More information about the llvm-commits mailing list