<div dir="ltr">Fine by me!</div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jun 2, 2017 at 3:10 AM, Joey Gouly via Phabricator <span dir="ltr"><<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">joey updated this revision to Diff 101179.<br>
joey added a comment.<br>
<br>
Thanks for that Craig, I had planned on looking at that today so thanks for doing it!<br>
<br>
I tested with <a href="https://reviews.llvm.org/D33801" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D33801</a> applied, and it fixes the completeness.ll test.<br>
<br>
Once Craig's review is finished, is this good to commit?<br>
<span class="im HOEnZb"><br>
<br>
<a href="https://reviews.llvm.org/D31194" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D31194</a><br>
<br>
Files:<br>
  lib/Analysis/<wbr>InstructionSimplify.cpp<br>
  test/Analysis/ConstantFolding/<wbr>gep-constanfolding-error.ll<br>
</span><div class="HOEnZb"><div class="h5">  test/Transforms/InstSimplify/<wbr>compare.ll<br>
  test/Transforms/InstSimplify/<wbr>simplify-nested-bitcast.ll<br>
  test/Transforms/InstSimplify/<wbr>vector_gep.ll<br>
  test/Transforms/NewGVN/<wbr>completeness.ll<br>
  test/Transforms/NewGVN/<wbr>loadforward.ll<br>
<br>
</div></div></blockquote></div><br></div>