[PATCH] D33785: [CodeView] Fix alignment / padding when writing symbol records

[Zachary Turner via Phabricator via llvm-commits]

zturner added a comment.

I don't think it should matter, because each record describes its own length, and that is the authority on how many bytes we need to skip to get to the next record.

On the other hand, I also don't think this patch really affects that.  We do all our writing of object files through `CodeViewDebug.cpp` and that doesn't use these classes (at least for the time being, it would be nice to merge these in the future).  So whatever object files we produced before, we will continue to produce.

So with that said, why bother even supporting both alignment styles?  It's nice to have this documented in code somehow, and it gives us some flexibility in the future if we ever decide that we must do it the way Microsoft does it that we can support whatever method we need with the flip of a switch.


https://reviews.llvm.org/D33785