[PATCH] D33785: [CodeView] Fix alignment / padding when writing symbol records

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 1 13:20:50 PDT 2017


rnk added a comment.

In https://reviews.llvm.org/D33785#770558, @zturner wrote:

> Updated with suggestions from inglorion.  Note that I actually fixed a bug with this update of the patch.  We weren't respecting the PDB / Object File alignment difference when writing the debug subsections, only when writing symbol records.  We still had the padding hardcoded to 4 in the debug subsections.  This definitely isn't true though, as I currently have this from a dump of an MSVC generated object file.


Do you think there is any harm to writing aligned symbol records into object files? If we were writing aligned records into object files before, I'd kind of like to maintain that property.


https://reviews.llvm.org/D33785





More information about the llvm-commits mailing list